Skip to content

Apply activation quantization parameters selection.#1487

Merged
gouda-youichi merged 5 commits intoSonySemiconductorSolutions:mainfrom
kkawa14:apply_actq_params_selection_for_node_inside_fln
Jul 7, 2025
Merged

Apply activation quantization parameters selection.#1487
gouda-youichi merged 5 commits intoSonySemiconductorSolutions:mainfrom
kkawa14:apply_actq_params_selection_for_node_inside_fln

Conversation

@gouda-youichi
Copy link
Copy Markdown
Contributor

@gouda-youichi gouda-youichi commented Jul 2, 2025

Apply activation quantization parameters selection (Stage3-4)

Pull Request Description:

Apply activation quantization parameters selection (Stage3-4)

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@gouda-youichi
Apply activation quantization parameters selection (#16)
aace81e 
Apply activation quantization parameters selection (#16)
@ofirgo ofirgo self-requested a review July 2, 2025 06:02
ofirgo
ofirgo suggested changes Jul 2, 2025
View reviewed changes
Comment thread model_compression_toolkit/core/common/quantization/node_quantization_config.py Outdated
Comment thread model_compression_toolkit/core/common/quantization/node_quantization_config.py Outdated
Comment thread ...ore/common/quantization/quantization_params_generation/test_calculate_quantization_params.py Outdated
This was referenced Jul 3, 2025
Closed
Merged
@gouda-youichi
Merge branch 'SonySemiconductorSolutions:main' into apply_actq_params…
ca3508a 
…_selection_for_node_inside_fln
@gouda-youichi
Apply activation quantization parameters selection(3rd PR internal re…
4230a8b 
…view) (#19)

Fixed PR comments.
- simplified a test.
- removed unnecessary codes.
- reverted about set_activation_quantization_param assert.
@gouda-youichi
Apply activation quantization parameters selection (solved test failu…
07e0b09 
…re.) (#20)

solved test failure.
ofirgo
ofirgo reviewed Jul 7, 2025
View reviewed changes
Comment thread ...tests/core/quantization/quantization_params_generation/test_calculate_quantization_params.py Outdated
graph.node_to_out_stats_collector[n].hc._bins = np.array(data)
graph.node_to_out_stats_collector[n].hc._counts = np.array([1, 1])

quant_config = QuantizationConfig()
Copy link
Copy Markdown
Contributor

@ofirgo ofirgo Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is the same (default QuantizationConfig) for all test cases, it is clearer to just initialized it in the test and not as part of the graph setup

@gouda-youichi
Apply activation quantization parameters selection (modify for quantc…
46367cf 
…onfig and remove unnecessary mocker arguement. (#21))

modify for quantconfig and remove unnecessary mocker arguement.
@gouda-youichi gouda-youichi merged commit fbd260e into SonySemiconductorSolutions:main Jul 7, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ofirgo ofirgo ofirgo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto:core pr: refactoring/code cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gouda-youichi @ofirgo